Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 47213005: Added geolocation (new); surfaced appcache and webaudio samples (Closed)

Created:
7 years, 1 month ago by shailentuli
Modified:
7 years, 1 month ago
Reviewers:
Kathy Walrath
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

Added geolocation (new); surfaced appcache and webaudio samples R=kathyw@google.com Committed: 28f0638

Patch Set 1 #

Total comments: 6

Patch Set 2 : Tweaks #

Patch Set 3 : Fixed geolocation url #

Total comments: 4

Patch Set 4 : More tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4013 lines, -4831 lines) Patch
M src/site/samples/appcache/index.markdown View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
A src/site/samples/geolocation/example/index.html View 1 chunk +33 lines, -0 lines 0 comments Download
A + src/site/samples/geolocation/example/trip_meter.css View 1 chunk +10 lines, -14 lines 0 comments Download
A src/site/samples/geolocation/example/trip_meter.dart View 1 chunk +53 lines, -0 lines 0 comments Download
A + src/site/samples/geolocation/example/trip_meter.dart.js View 135 chunks +1644 lines, -2019 lines 0 comments Download
A src/site/samples/geolocation/example/trip_meter.dart.js.deps View 1 chunk +122 lines, -0 lines 0 comments Download
A src/site/samples/geolocation/example/trip_meter.dart.js.map View 1 chunk +7 lines, -0 lines 0 comments Download
A + src/site/samples/geolocation/example/trip_meter.dart.precompiled.js View 189 chunks +2089 lines, -2793 lines 0 comments Download
A src/site/samples/geolocation/index.markdown View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
M src/site/samples/samples.yaml View 1 2 2 chunks +24 lines, -2 lines 0 comments Download
M src/site/samples/webaudio/index.markdown View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
shailentuli
This is for today's release. I've added a geolocation sample and surfaced the appcache and ...
7 years, 1 month ago (2013-10-28 14:51:36 UTC) #1
Kathy Walrath
Noticed a few things. Could I see this staged? https://chromiumcodereview.appspot.com/47213005/diff/1/src/site/samples/geolocation/index.markdown File src/site/samples/geolocation/index.markdown (right): https://chromiumcodereview.appspot.com/47213005/diff/1/src/site/samples/geolocation/index.markdown#newcode15 src/site/samples/geolocation/index.markdown:15: ...
7 years, 1 month ago (2013-10-28 15:26:37 UTC) #2
shailentuli
Staged version at: https://1028-dot-dart-lang.appspot.com/samples/ https://chromiumcodereview.appspot.com/47213005/diff/1/src/site/samples/geolocation/index.markdown File src/site/samples/geolocation/index.markdown (right): https://chromiumcodereview.appspot.com/47213005/diff/1/src/site/samples/geolocation/index.markdown#newcode15 src/site/samples/geolocation/index.markdown:15: device-agnostic; the underlying mechanism might ...
7 years, 1 month ago (2013-10-28 17:07:54 UTC) #3
Kathy Walrath
The page for appcache has a link to itself: "Or, you can try this live ...
7 years, 1 month ago (2013-10-28 18:08:04 UTC) #4
shailentuli
Committed patchset #4 manually as r28f0638 (presubmit successful).
7 years, 1 month ago (2013-10-28 19:08:01 UTC) #5
shailentuli
7 years, 1 month ago (2013-10-28 19:56:18 UTC) #6
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/47213005/diff/90001/src/site/samples/g...
File src/site/samples/geolocation/index.markdown (right):

https://chromiumcodereview.appspot.com/47213005/diff/90001/src/site/samples/g...
src/site/samples/geolocation/index.markdown:12:
[source](https://github.com/dart-lang/dart-samples/tree/master/web/html5/geolocation/trip_meter).
On 2013/10/28 18:08:04, Kathy Walrath wrote:
> The source link should be down by the example (for consistency with other
> pages).

Done.

https://chromiumcodereview.appspot.com/47213005/diff/90001/src/site/samples/g...
src/site/samples/geolocation/index.markdown:14: The Geolocation API lets you
track a user's location. The API is
On 2013/10/28 18:08:04, Kathy Walrath wrote:
> Does Geolocation really need to be capitalized?

It is the name of an API. So, yes.

Powered by Google App Engine
This is Rietveld 408576698