Display quic-connection-options passed in the command line in QUIC tab

Display quic-connection-options passed in the command line in QUIC tab
of net-internals page. connection-options also includes enable-pacing
argument which is displayed as PACE.

Fixes the rch's comments in https://codereview.chromium.org/471613002/

R=rch@chromium.org, thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290095

[Ryan Hamilton, 2014-08-14 03:46:07]

lgtm

https://codereview.chromium.org/470493004/diff/1/net/http/http_network_sessio...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/470493004/diff/1/net/http/http_network_sessio...
net/http/http_network_session.cc:262: dict->SetString("connection_options",
connection_options);
This is fine. There is also a ListValue which you could use here instead of a
StringValue. It might be simpler, but totally your call.

[ramant (doing other things), 2014-08-14 19:04:39]

PTAL.

https://codereview.chromium.org/470493004/diff/1/net/http/http_network_sessio...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/470493004/diff/1/net/http/http_network_sessio...
net/http/http_network_session.cc:262: dict->SetString("connection_options",
connection_options);
On 2014/08/14 03:46:07, Ryan Hamilton wrote:
> This is fine. There is also a ListValue which you could use here instead of a
> StringValue. It might be simpler, but totally your call.

Thanks much Ryan for the suggestion.

Done.

[Ryan Hamilton, 2014-08-14 19:19:10]

lgtm

[ramant (doing other things), 2014-08-14 19:50:10]

Hi thestig@,
  Could you take a look at chrome/browser changes (for OWNERS approval)?

    chrome/browser/resources/net_internals/quic_view.html

thanks much
raman

[Lei Zhang, 2014-08-14 20:33:54]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2014-08-14 20:33:55]

lgtm

[commit-bot: I haz the power, 2014-08-14 20:35:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/470493004/20001

[ramant (doing other things), 2014-08-14 23:41:08]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2014-08-15 22:03:44]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-15 22:05:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/470493004/20001

[eroman, 2014-08-15 22:38:02]

;

https://codereview.chromium.org/470493004/diff/20001/net/http/http_network_se...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/470493004/diff/20001/net/http/http_network_se...
net/http/http_network_session.cc:258: connection_options->AppendString("'" +
QuicUtils::TagToString(*it) + "'");
why is the string quoted?

[commit-bot: I haz the power, 2014-08-16 01:39:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-16 05:49:29]

Committed patchset #2 (20001) as 290095