Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: net/http/http_network_session.cc

Issue 470493004: Display quic-connection-options passed in the command line in QUIC tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Change_how_QUIC_negotiates_pacing_73061068
Patch Set: Use ListValue Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/net_internals/quic_view.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index cebbb1d4b7c0dda72efc3dd71043d7647da9b4bd..6a015787aa6c275757406822bf15156396aa8962 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -22,6 +22,7 @@
#include "net/quic/quic_crypto_client_stream_factory.h"
#include "net/quic/quic_protocol.h"
#include "net/quic/quic_stream_factory.h"
+#include "net/quic/quic_utils.h"
#include "net/socket/client_socket_factory.h"
#include "net/socket/client_socket_pool_manager_impl.h"
#include "net/socket/next_proto.h"
@@ -250,8 +251,13 @@ base::Value* HttpNetworkSession::QuicInfoToValue() const {
dict->SetBoolean("quic_enabled", params_.enable_quic);
dict->SetBoolean("enable_quic_port_selection",
params_.enable_quic_port_selection);
- dict->SetBoolean("enable_quic_pacing",
- ContainsQuicTag(params_.quic_connection_options, kPACE));
+ base::ListValue* connection_options = new base::ListValue;
+ for (QuicTagVector::const_iterator it =
+ params_.quic_connection_options.begin();
+ it != params_.quic_connection_options.end(); ++it) {
+ connection_options->AppendString("'" + QuicUtils::TagToString(*it) + "'");
eroman 2014/08/15 22:38:01 why is the string quoted?
+ }
+ dict->Set("connection_options", connection_options);
dict->SetBoolean("enable_quic_time_based_loss_detection",
params_.enable_quic_time_based_loss_detection);
dict->SetString("origin_to_force_quic_on",
« no previous file with comments | « chrome/browser/resources/net_internals/quic_view.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698