 Chromium Code Reviews
 Chromium Code Reviews Issue 459953002:
  Migrate geolocation permissions to the new common permission class.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 459953002:
  Migrate geolocation permissions to the new common permission class.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: content/public/browser/content_browser_client.cc | 
| diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc | 
| index 7802b852ed7fcc3874eb6fa3fd8c3cf3dc953dd8..3c8118f9c4141c178c96fbd77f8b07b714b17555 100644 | 
| --- a/content/public/browser/content_browser_client.cc | 
| +++ b/content/public/browser/content_browser_client.cc | 
| @@ -217,11 +217,18 @@ void ContentBrowserClient::RequestGeolocationPermission( | 
| int bridge_id, | 
| const GURL& requesting_frame, | 
| bool user_gesture, | 
| - base::Callback<void(bool)> result_callback, | 
| - base::Closure* cancel_callback) { | 
| + const base::Callback<void(bool)> result_callback) { | 
| 
Michael van Ouwerkerk
2014/08/13 10:01:11
Why does this need to be const?
 
Miguel Garcia
2014/08/13 13:18:13
Const ref. It does not need to but it's just nicer
 | 
| result_callback.Run(true); | 
| } | 
| +// TODO(miguelg): Create a small interface to represent a permission request | 
| +// instead of adding one method per permission and action. | 
| +void ContentBrowserClient::CancelGeolocationPermissionRequest( | 
| + WebContents* web_contents, | 
| + int bridge_id, | 
| + const GURL& requesting_frame) { | 
| +} | 
| + | 
| void ContentBrowserClient::RequestMidiSysExPermission( | 
| WebContents* web_contents, | 
| int bridge_id, |