Migrate geolocation permissions to the new common permission class.

content/public/browser/content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/content_browser_client.h"
 
 #include "base/files/file_path.h"
 #include "ui/gfx/image/image_skia.h"
 #include "url/gurl.h"
 
@@ skipping 199 matching lines @@
     ResourceContext* context,
     int render_process_id) {
   return blink::WebNotificationPermissionAllowed;
 }
 
 void ContentBrowserClient::RequestGeolocationPermission(
     WebContents* web_contents,
     int bridge_id,
     const GURL& requesting_frame,
     bool user_gesture,
-    base::Callback<void(bool)> result_callback,
-    base::Closure* cancel_callback) {
+    const base::Callback<void(bool)> result_callback) {

[Michael van Ouwerkerk, 2014/08/13 10:01:11]

Why does this need to be const?

[Miguel Garcia, 2014/08/13 13:18:13]

Const ref. It does not need to but it's just nicer I think and the underlying
permission check infrastructure uses a const ref already.

   result_callback.Run(true);
 }
 
+// TODO(miguelg): Create a small interface to represent a permission request
+// instead of adding one method per permission and action.
+void ContentBrowserClient::CancelGeolocationPermissionRequest(
+    WebContents* web_contents,
+    int bridge_id,
+    const GURL& requesting_frame) {
+}
+
 void ContentBrowserClient::RequestMidiSysExPermission(
     WebContents* web_contents,
     int bridge_id,
     const GURL& requesting_frame,
     bool user_gesture,
     base::Callback<void(bool)> result_callback,
     base::Closure* cancel_callback) {
   result_callback.Run(true);
 }
 
@@ skipping 109 matching lines @@
 
 #if defined(VIDEO_HOLE)
 ExternalVideoSurfaceContainer*
 ContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer(
     WebContents* web_contents) {
   return NULL;
 }
 #endif
 
 }  // namespace content