Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: Source/bindings/core/v8/ScriptCallStackFactory.cpp

Issue 458253002: [DevTools] Removed ScriptState from createScriptCallStackForConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptCallStackFactory.cpp
diff --git a/Source/bindings/core/v8/ScriptCallStackFactory.cpp b/Source/bindings/core/v8/ScriptCallStackFactory.cpp
index 00aca0e79d76d11ff5d4ca33205ba22d56df8f27..d176bcefc28d6fab9f182941b9df1f8aa3ffb05c 100644
--- a/Source/bindings/core/v8/ScriptCallStackFactory.cpp
+++ b/Source/bindings/core/v8/ScriptCallStackFactory.cpp
@@ -111,11 +111,12 @@ PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(size_t maxStackSiz
return createScriptCallStack(stackTrace, maxStackSize, emptyStackIsAllowed, isolate);
}
-PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(ScriptState* scriptState, size_t maxStackSize)
+PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(size_t maxStackSize)
{
size_t stackSize = 1;
if (InspectorInstrumentation::hasFrontends()) {
- if (InspectorInstrumentation::consoleAgentEnabled(scriptState->executionContext()))
+ v8::Isolate* isolate = v8::Isolate::GetCurrent();
+ if (InspectorInstrumentation::consoleAgentEnabled(currentExecutionContext(isolate)))
vsevik 2014/08/11 15:52:03 These lines might be needed here, please check wit
kozyatinskiy1 2014/08/11 16:05:34 First check added. @yurus, could you please answer
aandrey 2014/08/11 17:38:03 1) Calling currentExecutionContext() when not in c
kozyatinskiy1 2014/08/11 17:50:42 Thank you. Furthermore, this test may be useful he
stackSize = maxStackSize;
}
return createScriptCallStack(stackSize);

Powered by Google App Engine
This is Rietveld 408576698