Source/core/inspector/InspectorConsoleAgent.cpp - Issue 458253002: [DevTools] Removed ScriptState from createScriptCallStackForConsole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorConsoleAgent.cpp

Issue 458253002: [DevTools] Removed ScriptState from createScriptCallStackForConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptCallStackFactory.cpp ('K') | « Source/core/frame/ConsoleBase.idl ('k') | Source/core/inspector/InspectorConsoleMessage.cpp » ('j') | Source/core/inspector/InspectorProfilerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorConsoleAgent.cpp

diff --git a/Source/core/inspector/InspectorConsoleAgent.cpp b/Source/core/inspector/InspectorConsoleAgent.cpp

index 737e601dc4cd1736709f15a93c6d83d6d736db48..ed6188a4a57a981fc4a208d470a51f621965ac27 100644

--- a/Source/core/inspector/InspectorConsoleAgent.cpp

+++ b/Source/core/inspector/InspectorConsoleAgent.cpp

@@ -169,7 +169,7 @@ void InspectorConsoleAgent::clearFrontend()

void InspectorConsoleAgent::addMessageToConsole(ConsoleMessage* consoleMessage)

{

if (consoleMessage->callStack()) {

- addConsoleMessage(adoptPtr(new InspectorConsoleMessage(!isWorkerAgent(), consoleMessage->source(), LogMessageType, consoleMessage->level(), consoleMessage->message(), consoleMessage->callStack(), consoleMessage->requestIdentifier())));

+ addConsoleMessage(adoptPtr(new InspectorConsoleMessage(false, consoleMessage->source(), LogMessageType, consoleMessage->level(), consoleMessage->message(), consoleMessage->callStack(), consoleMessage->requestIdentifier())));

vsevik 2014/08/11 15:52:03 Let's remove this parameter.

kozyatinskiy1 2014/08/11 16:05:34 Done.

} else {

bool canGenerateCallStack = !isWorkerAgent() && m_frontend;

addConsoleMessage(adoptPtr(new InspectorConsoleMessage(canGenerateCallStack, consoleMessage->source(), LogMessageType, consoleMessage->level(), consoleMessage->message(), consoleMessage->url(), consoleMessage->lineNumber(), consoleMessage->columnNumber(), consoleMessage->scriptState(), consoleMessage->requestIdentifier())));

@@ -247,7 +247,7 @@ void InspectorConsoleAgent::consoleTimelineEnd(ExecutionContext* context, const

void InspectorConsoleAgent::consoleCount(ScriptState* scriptState, PassRefPtrWillBeRawPtr<ScriptArguments> arguments)

{

- RefPtrWillBeRawPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(scriptState, 1));

+ RefPtrWillBeRawPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(1));

const ScriptCallFrame& lastCaller = callStack->at(0);

// Follow Firebug's behavior of counting with null and undefined title in

// the same bucket as no argument