chrome/browser/resources/contextual_search/promo.html - Issue 456833003: [Search] Make the text swoosh away off the screen when the user taps the opt-in link.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/contextual_search/promo.html

Issue 456833003: [Search] Make the text swoosh away off the screen when the user taps the opt-in link. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/contextual_search/promo.css ('K') | « chrome/browser/resources/contextual_search/promo.css ('k') | chrome/browser/resources/contextual_search/promo.js » ('j') | chrome/browser/resources/contextual_search/promo.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/contextual_search/promo.html

diff --git a/chrome/browser/resources/contextual_search/promo.html b/chrome/browser/resources/contextual_search/promo.html

index c0655760ceaed233cef20534eaec06c44ba11ac0..100ce012515252725ead77899096713231b95b43 100644

--- a/chrome/browser/resources/contextual_search/promo.html

+++ b/chrome/browser/resources/contextual_search/promo.html

@@ -12,10 +12,12 @@

</head>

<body>

- <p i18n-content="description"></p>

- <div id="button-container">

- <span class="label"><a href="#optout" i18n-content="optOut"></a></span>

- <span class="label"><a class="colored" href="#optin" i18n-content="optIn"></a></span>

+ <div id="container">

+ <p i18n-content="description"></p>

+ <div id="button-container">

+ <span class="label"><a href="#optout" i18n-content="optOut"></a></span>

+ <span class="label" onclick="addSlideClass()"><a class="colored" href="#optin" i18n-content="optIn"></a></span>

huangs 2014/08/11 16:10:51 Better style is to inject handler from JS, since i

pedro (no code reviews) 2014/08/11 17:54:06 +1

Mathieu 2014/08/11 21:11:03 Done.

+ </div>

</div>

</body>

</html>