chrome/browser/resources/contextual_search/promo.html - Issue 456833003: [Search] Make the text swoosh away off the screen when the user taps the opt-in link.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/contextual_search/promo.html

Issue 456833003: [Search] Make the text swoosh away off the screen when the user taps the opt-in link. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/contextual_search/promo.css ('K') | « chrome/browser/resources/contextual_search/promo.css ('k') | chrome/browser/resources/contextual_search/promo.js » ('j') | chrome/browser/resources/contextual_search/promo.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file. -->	5 found in the LICENSE file. -->

6 <head>	6 <head>

7 <script src="promo.js"></script>	7 <script src="promo.js"></script>

8 <script src="../../../../ui/webui/resources/js/util.js"></script>	8 <script src="../../../../ui/webui/resources/js/util.js"></script>

9 <script src="../../../../ui/webui/resources/js/load_time_data.js"></script>	9 <script src="../../../../ui/webui/resources/js/load_time_data.js"></script>

10 <link rel="stylesheet" href="promo.css">	10 <link rel="stylesheet" href="promo.css">

11 <meta charset="utf-8">	11 <meta charset="utf-8">

12 <meta name="viewport" content="width=device-width, user-scalable=no">	12 <meta name="viewport" content="width=device-width, user-scalable=no">

13 </head>	13 </head>

14 <body>	14 <body>

15 <p i18n-content="description"></p>	15 <div id="container">

16 <div id="button-container">	16 <p i18n-content="description"></p>

17 <span class="label"><a href="#optout" i18n-content="optOut"></a></span>	17 <div id="button-container">

18 <span class="label"><a class="colored" href="#optin" i18n-content="optIn"></ a></span>	18 <span class="label"><a href="#optout" i18n-content="optOut"></a></span>

	19 <span class="label" onclick="addSlideClass()"><a class="colored" href="#op tin" i18n-content="optIn"></a></span>
	huangs 2014/08/11 16:10:51 Better style is to inject handler from JS, since i Better style is to inject handler from JS, since in this case you won't need to have global function as handler. Though now you'll have to grab label somehow. pedro (no code reviews) 2014/08/11 17:54:06 +1 Show quoted text On 2014/08/11 16:10:51, huangs1 wrote: > Better style is to inject handler from JS, since in this case you won't need to > have global function as handler. Though now you'll have to grab label somehow. +1 Mathieu 2014/08/11 21:11:03 Done. Show quoted text On 2014/08/11 16:10:51, huangs1 wrote: > Better style is to inject handler from JS, since in this case you won't need to > have global function as handler. Though now you'll have to grab label somehow. Done. Mathieu 2014/08/11 21:11:03 Done. Show quoted text On 2014/08/11 17:54:06, pedrosimonetti wrote: > On 2014/08/11 16:10:51, huangs1 wrote: > > Better style is to inject handler from JS, since in this case you won't need > to > > have global function as handler. Though now you'll have to grab label > somehow. > > +1 Done.
	20 </div>

19 </div>	21 </div>

20 </body>	22 </body>

21 </html>	23 </html>

OLD	NEW