Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 453093005: Regeneration and redirects for book content (Closed)

Created:
6 years, 4 months ago by Kathy Walrath
Modified:
6 years, 4 months ago
Reviewers:
sethladd
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

Regeneration and redirects for book content Changes include: - Change example to use FormatException instead of ExpectException. - Don't say local vars are lazily initialized. - Better code for the sin() example. - Better comments (and updated code) for the hide elements example. - Delete all dart-vm content. - Redirect dart-vm and dart2js to /tools/*. Staged at URLS such as: https://book-dot-dart-lang.appspot.com/docs/dart-up-and-running/contents/ch02.html https://book-dot-dart-lang.appspot.com/docs/dart-up-and-running/contents/ch03.html https://book-dot-dart-lang.appspot.com/docs/dart-up-and-running/contents/ch04.html XML diffs (probably easier to read than these, but still some randomness due to the editor changing some line lengths): https://github.com/dart-lang/dart-up-and-running-book/pull/44 BUG= http://dartbug.com/19048 http://dartbug.com/19049 http://dartbug.com/18671 http://dartbug.com/15554 http://dartbug.com/17668 R=sethladd@google.com Committed: d25ee99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -65 lines) Patch
M src/appengine/app.yaml View 1 chunk +6 lines, -0 lines 0 comments Download
M src/appengine/scripts/redirector.py View 1 chunk +4 lines, -0 lines 0 comments Download
M src/site/docs/dart-up-and-running/contents/ch02.html View 4 chunks +11 lines, -13 lines 0 comments Download
M src/site/docs/dart-up-and-running/contents/ch03.html View 14 chunks +23 lines, -22 lines 0 comments Download
M src/site/docs/dart-up-and-running/contents/ch04.html View 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/dart-up-and-running/contents/ch04-tools-dart-vm.html View 1 chunk +1 line, -24 lines 0 comments Download
M src/site/docs/dart-up-and-running/contents/ch05.html View 2 chunks +2 lines, -2 lines 0 comments Download
M src/site/docs/dart-up-and-running/contents/index.html View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kathy Walrath
Fixing all the book bugs in one swell foop.
6 years, 4 months ago (2014-08-08 23:38:52 UTC) #1
sethladd
Nice, thanks!
6 years, 4 months ago (2014-08-09 06:32:47 UTC) #2
sethladd
Oh, and LGTM
6 years, 4 months ago (2014-08-09 06:33:01 UTC) #3
Kathy Walrath
6 years, 4 months ago (2014-08-11 18:04:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as rd25ee99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698