Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: ui/webui/resources/js/cr/ui/page_manager/page.js

Issue 443553002: Typecheck chrome://help using CompilerPass.java, everything except dependency to options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master
Patch Set: rebase to master, compile everything but dependency to options Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/js/cr/ui/page_manager/page.js
diff --git a/ui/webui/resources/js/cr/ui/page_manager/page.js b/ui/webui/resources/js/cr/ui/page_manager/page.js
index b9d92593c7ec8638dc32cf45613992e5185d296d..abb01f8865c3a894c2c39c93767e7bd5f09dd017 100644
--- a/ui/webui/resources/js/cr/ui/page_manager/page.js
+++ b/ui/webui/resources/js/cr/ui/page_manager/page.js
@@ -15,7 +15,6 @@ cr.define('cr.ui.pageManager', function() {
* @param {string} name Page name.
* @param {string} title Page title, used for history.
* @param {string} pageDivName ID of the div corresponding to the page.
- * @extends {EventTarget}
Dan Beam 2014/08/13 22:20:08 this needs to match with the __proto__ line
Vitaly Pavlenko 2014/08/14 00:01:02 Done.
*/
function Page(name, title, pageDivName) {
this.name = name;
@@ -35,7 +34,7 @@ cr.define('cr.ui.pageManager', function() {
/**
* The parent page of this page, or null for root pages.
- * @type {Page}
+ * @type {cr.ui.pageManager.Page}
*/
parentPage: null,
@@ -243,6 +242,7 @@ cr.define('cr.ui.pageManager', function() {
pageDiv.page = this;
// NOTE: This is a hacky way to force the container to layout which
// will allow us to trigger the webkit transition.
+ /** @suppress {uselessCode} */
container.scrollTop;
this.pageDiv.removeAttribute('aria-hidden');

Powered by Google App Engine
This is Rietveld 408576698