Typecheck chrome://help using CompilerPass.java, everything except dependency to options

ui/webui/resources/js/cr/ui/page_manager/page_manager.js

Index: ui/webui/resources/js/cr/ui/page_manager/page_manager.js
diff --git a/ui/webui/resources/js/cr/ui/page_manager/page_manager.js b/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
index 6f9f1cce3ffe6bd8bccb1c84cb3e3a46d359816e..ebefee1c4b5a822872e018be8dfed19f2e783ebd 100644
--- a/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
+++ b/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
@@ -44,7 +44,7 @@ cr.define('cr.ui.pageManager', function() {
 
     /**
      * Observers will be notified when opening and closing overlays.
-     * @type {!Array.<!PageManager.Observer>}
+     * @type {!Array.<!cr.ui.pageManager.PageManager.Observer>}
      */
     observers_: [],
 
@@ -76,7 +76,7 @@ cr.define('cr.ui.pageManager', function() {
 
     /**
      * Registers new page.
-     * @param {cr.ui.page_manager.Page} page Page to register.
+     * @param {cr.ui.pageManager.Page} page Page to register.

[Dan Beam, 2014/08/13 22:20:08]

seems like this probably ought to be !cr.ui.pageManager.Page instead, right?

[Vitaly Pavlenko, 2014/08/14 00:01:03]

Done.

      */
     register: function(page) {
       this.registeredPages[page.name.toLowerCase()] = page;
@@ -85,8 +85,8 @@ cr.define('cr.ui.pageManager', function() {
 
     /**
      * Registers a new Overlay page.
-     * @param {cr.ui.page_manager.Page} overlay Overlay to register.
-     * @param {cr.ui.page_manager.Page} parentPage Associated parent page for
+     * @param {cr.ui.pageManager.Page} overlay Overlay to register.
+     * @param {cr.ui.pageManager.Page} parentPage Associated parent page for

[Dan Beam, 2014/08/13 22:20:08]

^ and here as well (with the !)

[Vitaly Pavlenko, 2014/08/14 00:01:03]

Only for overlay. For parentPage there are checks for being true when it's used.

      *     this overlay.
      * @param {Array} associatedControls Array of control elements associated
      *     with this page.
@@ -400,7 +400,7 @@ cr.define('cr.ui.pageManager', function() {
 
     /**
      * Returns the currently visible bubble, or null if no bubble is visible.
-     * @return {AutoCloseBubble} The bubble currently being shown.
+     * @return {cr.ui.AutoCloseBubble} The bubble currently being shown.
      */
     getVisibleBubble: function() {
       var bubble = this.bubble_;
@@ -463,7 +463,8 @@ cr.define('cr.ui.pageManager', function() {
     },
 
     /**
-     * @param {PageManager.Observer} observer The observer to register.
+     * @param {cr.ui.pageManager.PageManager.Observer} observer The observer to

[Dan Beam, 2014/08/13 22:20:08]

nit: !

[Vitaly Pavlenko, 2014/08/14 00:01:03]

Done.

+     *     register.
      */
     addObserver: function(observer) {
       this.observers_.push(observer);
@@ -597,7 +598,7 @@ cr.define('cr.ui.pageManager', function() {
      * to update the history.
      * @param {boolean} replace If true, handlers should replace the current
      *     history event rather than create new ones.
-     * @param {object=} opt_params A bag of optional params, including:
+     * @param {Object=} opt_params A bag of optional params, including:
      *     {boolean} ignoreHash Whether to include the hash or not.
      * @private
      */
@@ -637,8 +638,8 @@ cr.define('cr.ui.pageManager', function() {
 
     /**
      * Find an enclosing section for an element if it exists.
-     * @param {Element} element Element to search.
-     * @return {Element} The section element, or null.
+     * @param {Node} node Element to search.
+     * @return {Node} The section element, or null.
      * @private
      */
     findSectionForNode_: function(node) {