Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 419673002: Update Android menu to overlap anchor (Closed)

Created:
6 years, 5 months ago by David Trainor- moved to gerrit
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update Android menu to overlap anchor - Fix menu bg asset to properly allow the menu to overlap the anchor - Turn on dismiss button in menu - Fix some animation code related to the dismiss button in the menu - Make overlapping an RTL item work properly BUG=394898 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285728

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Total comments: 8

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -38 lines) Patch
M chrome/android/java/res/anim/menu_enter.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/anim/menu_exit.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/four_button_menu_item.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/title_button_menu_item.xml View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/res/values-ldrtl/values.xml View 1 chunk +3 lines, -5 lines 0 comments Download
D chrome/android/java/res/values-sw600dp/dimens.xml View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/values/values.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 7 chunks +15 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 1 2 8 chunks +31 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
David Trainor- moved to gerrit
ptal thanks! will land the assets separately.
6 years, 5 months ago (2014-07-25 00:26:31 UTC) #1
aurimas (slooooooooow)
lgtm https://chromiumcodereview.appspot.com/419673002/diff/1/chrome/android/java/res/anim/menu_enter.xml File chrome/android/java/res/anim/menu_enter.xml (right): https://chromiumcodereview.appspot.com/419673002/diff/1/chrome/android/java/res/anim/menu_enter.xml#newcode13 chrome/android/java/res/anim/menu_enter.xml:13: android:pivotX="@fraction/menu_animation_pivot_x" android:pivotY="5%" Can you put android:pivotY=.. on a ...
6 years, 5 months ago (2014-07-25 16:45:56 UTC) #2
David Trainor- moved to gerrit
https://chromiumcodereview.appspot.com/419673002/diff/1/chrome/android/java/res/anim/menu_enter.xml File chrome/android/java/res/anim/menu_enter.xml (right): https://chromiumcodereview.appspot.com/419673002/diff/1/chrome/android/java/res/anim/menu_enter.xml#newcode13 chrome/android/java/res/anim/menu_enter.xml:13: android:pivotX="@fraction/menu_animation_pivot_x" android:pivotY="5%" On 2014/07/25 16:45:55, aurimas wrote: > Can ...
6 years, 5 months ago (2014-07-25 18:09:26 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/layout/four_button_menu_item.xml File chrome/android/java/res/layout/four_button_menu_item.xml (left): https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/layout/four_button_menu_item.xml#oldcode46 chrome/android/java/res/layout/four_button_menu_item.xml:46: Huh? https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/layout/title_button_menu_item.xml File chrome/android/java/res/layout/title_button_menu_item.xml (right): https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/layout/title_button_menu_item.xml#newcode30 chrome/android/java/res/layout/title_button_menu_item.xml:30: Huh? https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/values-ldrtl/values.xml ...
6 years, 5 months ago (2014-07-25 18:21:03 UTC) #4
David Trainor- moved to gerrit
https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/layout/four_button_menu_item.xml File chrome/android/java/res/layout/four_button_menu_item.xml (left): https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/layout/four_button_menu_item.xml#oldcode46 chrome/android/java/res/layout/four_button_menu_item.xml:46: On 2014/07/25 18:21:03, aurimas wrote: > Huh? Done. https://chromiumcodereview.appspot.com/419673002/diff/20001/chrome/android/java/res/layout/title_button_menu_item.xml ...
6 years, 5 months ago (2014-07-25 20:01:18 UTC) #5
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 5 months ago (2014-07-25 23:43:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/419673002/20002
6 years, 5 months ago (2014-07-25 23:45:17 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 23:53:24 UTC) #8
Message was sent while issue was closed. 
Change committed as 285728

Powered by Google App Engine
This is Rietveld 408576698