chrome/android/java/res/layout/four_button_menu_item.xml - Issue 419673002: Update Android menu to overlap anchor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/four_button_menu_item.xml

Issue 419673002: Update Android menu to overlap anchor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/android/java/res/drawable-xxhdpi/menu_bg.9.png ('k') | chrome/android/java/res/layout/title_button_menu_item.xml » ('j') | chrome/android/java/res/layout/title_button_menu_item.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

8 android:layout_width="match_parent"	8 android:layout_width="match_parent"

9 android:layout_height="?android:attr/listPreferredItemHeightSmall"	9 android:layout_height="?android:attr/listPreferredItemHeightSmall"

10 android:layout_gravity="top\|start"	10 android:layout_gravity="top\|start"

(...skipping 25 matching lines...) Expand all Loading...
36 android:background="?android:attr/listChoiceBackgroundIndicator"	36 android:background="?android:attr/listChoiceBackgroundIndicator"

37 android:scaleType="center" />	37 android:scaleType="center" />

38	38

39 <ImageButton	39 <ImageButton

40 android:id="@+id/button_four"	40 android:id="@+id/button_four"

41 android:layout_width="59dp"	41 android:layout_width="59dp"

42 android:layout_height="match_parent"	42 android:layout_height="match_parent"

43 android:paddingStart="11dp"	43 android:paddingStart="11dp"

44 android:background="?android:attr/listChoiceBackgroundIndicator"	44 android:background="?android:attr/listChoiceBackgroundIndicator"

45 android:scaleType="center" />	45 android:scaleType="center" />

46
aurimas (slooooooooow) 2014/07/25 18:21:03 Huh? Huh? David Trainor- moved to gerrit 2014/07/25 20:01:17 Done. Show quoted text On 2014/07/25 18:21:03, aurimas wrote: > Huh? Done.
47 </LinearLayout>	46 </LinearLayout>

OLD	NEW