Source/modules/webdatabase/DatabaseManager.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/DatabaseManager.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerReportingProxy.h ('K') | « Source/modules/webdatabase/DatabaseBackendBase.cpp ('k') | Source/modules/websockets/DOMWebSocket.cpp » ('j') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/DatabaseManager.cpp

diff --git a/Source/modules/webdatabase/DatabaseManager.cpp b/Source/modules/webdatabase/DatabaseManager.cpp

index f5ec70497b017a5d679d28dbac7d03163bbdce1f..8d79fb40d5b51c7dcd4756e2891ad77cac51b85c 100644

--- a/Source/modules/webdatabase/DatabaseManager.cpp

+++ b/Source/modules/webdatabase/DatabaseManager.cpp

@@ -31,6 +31,7 @@

#include "core/dom/ExceptionCode.h"

#include "core/dom/ExecutionContext.h"

#include "core/dom/ExecutionContextTask.h"

+#include "core/inspector/ConsoleMessage.h"

#include "platform/Logging.h"

#include "modules/webdatabase/AbstractDatabaseServer.h"

#include "modules/webdatabase/Database.h"

@@ -276,7 +277,7 @@ void DatabaseManager::interruptAllDatabasesForContext(DatabaseContext* databaseC

void DatabaseManager::logErrorMessage(ExecutionContext* context, const String& message)

{

- context->addConsoleMessage(StorageMessageSource, ErrorMessageLevel, message);

+ context->addConsoleMessage(ConsoleMessage::create(StorageMessageSource, ErrorMessageLevel, message));

}

} // namespace blink