Source/modules/webdatabase/DatabaseBackendBase.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/DatabaseBackendBase.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerReportingProxy.h ('K') | « Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp ('k') | Source/modules/webdatabase/DatabaseManager.cpp » ('j') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/DatabaseBackendBase.cpp

diff --git a/Source/modules/webdatabase/DatabaseBackendBase.cpp b/Source/modules/webdatabase/DatabaseBackendBase.cpp

index b234b7c3ed037378b7bcee0c8d6e0ce62c496f21..fdb7af3055fc3db34bc275a13e33d85fe0ce6638 100644

--- a/Source/modules/webdatabase/DatabaseBackendBase.cpp

+++ b/Source/modules/webdatabase/DatabaseBackendBase.cpp

@@ -32,6 +32,7 @@

#include "core/dom/ExceptionCode.h"

#include "core/dom/ExecutionContext.h"

+#include "core/inspector/ConsoleMessage.h"

#include "platform/Logging.h"

#include "modules/webdatabase/DatabaseAuthorizer.h"

#include "modules/webdatabase/DatabaseBase.h"

@@ -664,7 +665,7 @@ void DatabaseBackendBase::reportVacuumDatabaseResult(int sqliteErrorCode)

void DatabaseBackendBase::logErrorMessage(const String& message)

{

- executionContext()->addConsoleMessage(StorageMessageSource, ErrorMessageLevel, message);

+ executionContext()->addConsoleMessage(ConsoleMessage::create(StorageMessageSource, ErrorMessageLevel, message));

}

ExecutionContext* DatabaseBackendBase::executionContext() const