Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: Source/core/workers/WorkerGlobalScope.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/workers/WorkerGlobalScope.h
diff --git a/Source/core/workers/WorkerGlobalScope.h b/Source/core/workers/WorkerGlobalScope.h
index 0764094debf90ec14b090ea9350b0c93b4ba1bb2..def8f504a0b7f3b8bd9281e07272ce3720fd273e 100644
--- a/Source/core/workers/WorkerGlobalScope.h
+++ b/Source/core/workers/WorkerGlobalScope.h
@@ -34,6 +34,7 @@
#include "core/frame/DOMWindowBase64.h"
#include "core/frame/UseCounter.h"
#include "core/frame/csp/ContentSecurityPolicy.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/workers/WorkerEventQueue.h"
#include "platform/heap/Handle.h"
#include "platform/network/ContentSecurityPolicyParsers.h"
@@ -143,7 +144,7 @@ namespace blink {
void applyContentSecurityPolicyFromString(const String& contentSecurityPolicy, ContentSecurityPolicyHeaderType);
virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) OVERRIDE;
- void addMessageToWorkerConsole(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>, ScriptState*);
+ void addMessageToWorkerConsole(PassRefPtr<ConsoleMessage>);
private:
#if !ENABLE(OILPAN)
@@ -155,7 +156,7 @@ namespace blink {
virtual KURL virtualCompleteURL(const String&) const OVERRIDE FINAL;
virtual void reportBlockedScriptExecutionToInspector(const String& directiveText) OVERRIDE FINAL;
- virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState* = 0) OVERRIDE FINAL;
+ virtual void addMessage(PassRefPtr<ConsoleMessage>) OVERRIDE FINAL;
virtual EventTarget* errorEventTarget() OVERRIDE FINAL;
virtual void didUpdateSecurityOrigin() OVERRIDE FINAL { }

Powered by Google App Engine
This is Rietveld 408576698