Source/core/workers/WorkerConsole.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerConsole.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/workers/SharedWorkerGlobalScope.cpp ('k') | Source/core/workers/WorkerGlobalScope.h » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/WorkerConsole.cpp

diff --git a/Source/core/workers/WorkerConsole.cpp b/Source/core/workers/WorkerConsole.cpp

index ebaa0b3482e45ffc70dccb2aad092c2b89316d86..f2486755b95809423f1808d2a0f40986b661bf84 100644

--- a/Source/core/workers/WorkerConsole.cpp

+++ b/Source/core/workers/WorkerConsole.cpp

@@ -31,6 +31,7 @@

#include "core/workers/WorkerConsole.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/ScriptCallStack.h"

#include "core/workers/WorkerGlobalScope.h"

#include "core/workers/WorkerReportingProxy.h"

@@ -52,7 +53,7 @@ WorkerConsole::~WorkerConsole()

void WorkerConsole::reportMessageToClient(MessageLevel level, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)

{

const ScriptCallFrame& lastCaller = callStack->at(0);

- m_scope->thread()->workerReportingProxy().reportConsoleMessage(ConsoleAPIMessageSource, level, message, lastCaller.lineNumber(), lastCaller.sourceURL());

+ m_scope->thread()->workerReportingProxy().reportConsoleMessage(ConsoleMessage::create(ConsoleAPIMessageSource, level, message, lastCaller.sourceURL(), lastCaller.lineNumber()));

}

ExecutionContext* WorkerConsole::context()