Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: Source/core/html/HTMLMetaElement-in.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMetaElement-in.cpp
diff --git a/Source/core/html/HTMLMetaElement-in.cpp b/Source/core/html/HTMLMetaElement-in.cpp
index 2e74fb1ebd5c0df8df257cfa9d17f897f71751ec..1a88b7135160c7fc9cc090ff8c8e2ea51851759f 100644
--- a/Source/core/html/HTMLMetaElement-in.cpp
+++ b/Source/core/html/HTMLMetaElement-in.cpp
@@ -27,6 +27,7 @@
#include "core/dom/Document.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/loader/FrameLoaderClient.h"
#include "platform/RuntimeEnabledFeatures.h"
@@ -128,7 +129,7 @@ void HTMLMetaElement::parseContentAttribute(const String& content, KeyValuePairC
}
if (error) {
String message = "Error parsing a meta element's content: ';' is not a valid key-value pair separator. Please use ',' instead.";
- document().addConsoleMessage(RenderingMessageSource, WarningMessageLevel, message);
+ document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, WarningMessageLevel, message));
}
}
@@ -392,7 +393,7 @@ void HTMLMetaElement::reportViewportWarning(ViewportErrorCode errorCode, const S
message.replace("%replacement2", replacement2);
// FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
- document().addConsoleMessage(RenderingMessageSource, viewportErrorMessageLevel(errorCode), message);
+ document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, viewportErrorMessageLevel(errorCode), message));
}
void HTMLMetaElement::processViewportContentAttribute(const String& content, ViewportDescription::Type origin)

Powered by Google App Engine
This is Rietveld 408576698