Source/core/html/HTMLShadowElement.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLShadowElement.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/html/HTMLMetaElement-in.cpp ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLShadowElement.cpp

diff --git a/Source/core/html/HTMLShadowElement.cpp b/Source/core/html/HTMLShadowElement.cpp

index e8e67469dce0f185782a9bc4928672d1af9b6574..ec28d2cf5cecd7258689f28feaad5bf6e8c49ef9 100644

--- a/Source/core/html/HTMLShadowElement.cpp

+++ b/Source/core/html/HTMLShadowElement.cpp

@@ -34,6 +34,7 @@

#include "core/HTMLNames.h"

#include "core/dom/Document.h"

#include "core/dom/shadow/ShadowRoot.h"

+#include "core/inspector/ConsoleMessage.h"

namespace blink {

@@ -74,7 +75,7 @@ Node::InsertionNotificationRequest HTMLShadowElement::insertedInto(ContainerNode

ShadowRoot* root = containingShadowRoot();

if (root && root->olderShadowRoot() && root->type() != root->olderShadowRoot()->type()) {

String message = String::format("<shadow> doesn't work for %s element host.", root->host()->tagName().utf8().data());

- document().addConsoleMessage(RenderingMessageSource, WarningMessageLevel, message);

+ document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, WarningMessageLevel, message));

}

return InsertionPoint::insertedInto(insertionPoint);