Source/core/html/HTMLFormControlElement.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/frame/csp/ContentSecurityPolicy.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormControlElement.cpp

diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp

index a4e37a36cc362f9912230017706c1f74ee3793f4..05ea7c99d2a7626a8bbcf0bb5616890b4d125c69 100644

--- a/Source/core/html/HTMLFormControlElement.cpp

+++ b/Source/core/html/HTMLFormControlElement.cpp

@@ -33,6 +33,7 @@

#include "core/html/HTMLLegendElement.h"

#include "core/html/ValidityState.h"

#include "core/frame/UseCounter.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/page/Page.h"

#include "core/page/ValidationMessageClient.h"

#include "core/rendering/RenderBox.h"

@@ -211,7 +212,7 @@ static bool shouldAutofocusOnAttach(const HTMLFormControlElement* element)

return false;

if (element->document().isSandboxed(SandboxAutomaticFeatures)) {

// FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.

- element->document().addConsoleMessage(SecurityMessageSource, ErrorMessageLevel, "Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set.");

+ element->document().addConsoleMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set."));

return false;

}