Source/core/frame/csp/ContentSecurityPolicy.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/csp/ContentSecurityPolicy.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/frame/csp/CSPDirectiveList.cpp ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/csp/ContentSecurityPolicy.cpp

diff --git a/Source/core/frame/csp/ContentSecurityPolicy.cpp b/Source/core/frame/csp/ContentSecurityPolicy.cpp

index 7f6566652906bce1aa84d615765e252285c885cf..d06f0afb7cbc83840918a7ad298796d62ccb172c 100644

--- a/Source/core/frame/csp/ContentSecurityPolicy.cpp

+++ b/Source/core/frame/csp/ContentSecurityPolicy.cpp

@@ -39,6 +39,7 @@

#include "core/frame/csp/CSPSourceList.h"

#include "core/frame/csp/MediaListDirective.h"

#include "core/frame/csp/SourceListDirective.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/ScriptCallStack.h"

#include "core/loader/DocumentLoader.h"

@@ -758,7 +759,7 @@ void ContentSecurityPolicy::reportMissingReportURI(const String& policy) const

void ContentSecurityPolicy::logToConsole(const String& message, MessageLevel level) const

{

- m_executionContext->addConsoleMessage(SecurityMessageSource, level, message);

+ m_executionContext->addConsoleMessage(ConsoleMessage::create(SecurityMessageSource, level, message));

}

void ContentSecurityPolicy::reportBlockedScriptExecutionToInspector(const String& directiveText) const