Don't include class-static functions in library mirror.

Don't include class-static functions in library mirror.

Also removes code that checked if a library-function was a constructor.

BUG= http://dartbug.com/12133

Committed: https://code.google.com/p/dart/source/detail?r=38589
Reverted: https://code.google.com/p/dart/source/detail?r=38590

Committed: https://code.google.com/p/dart/source/detail?r=38593
Reverted: https://code.google.com/p/dart/source/detail?r=38601

[ahe, 2014-07-24 18:23:34]

lgtm

[floitsch, 2014-07-25 20:43:03]

Committed patchset #1 manually as r38589 (presubmit successful).

[floitsch, 2014-07-25 21:22:14]

Committed patchset #1 manually as r38593 (presubmit successful).

[floitsch, 2014-07-28 17:47:23]

PTAL.
The reason the check was needed, was because of the bug that we added static
class functions to the library mirror.

[ahe, 2014-08-04 09:19:40]

LGTM!

https://chromiumcodereview.appspot.com/416873002/diff/40001/sdk/lib/_internal...
File
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
(right):

https://chromiumcodereview.appspot.com/416873002/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:216:
if (!init.staticFunctions) init.staticFunctions = map();
At first, this change put me off. Then I checked the specification of
MethodMirror.isStatic, and it does say that top-level functions are also
considered static. This is slightly confusing, because we don't allow the static
keyword on top-level functions.

What "isStatic" really means is "not an instance method, and not a constructor".

Regardless, using the term "staticFunctions" matches the use in dart:mirrors. So
I'm no longer put off by this change.

In other parts of the compiler, we have used the terminology "global" to refer
to static and top-level elements (I actually think that you introduced this
term). For that reason, I suggest you change the above comment to say:

[staticFunctions] contains all static functions (including top-level functions).
This is used ...

https://chromiumcodereview.appspot.com/416873002/diff/40001/tests/lib/mirrors...
File tests/lib/mirrors/library_declarations2_test.dart (right):

https://chromiumcodereview.appspot.com/416873002/diff/40001/tests/lib/mirrors...
tests/lib/mirrors/library_declarations2_test.dart:5: library
test.library_declarations_test;
For consistency, consider changing name to match file name (add 2 after
declarations).

https://chromiumcodereview.appspot.com/416873002/diff/40001/tests/lib/mirrors...
tests/lib/mirrors/library_declarations2_test.dart:7: @MirrorsUsed(targets:
"test.library_declarations_test")
Ditto.

https://chromiumcodereview.appspot.com/416873002/diff/40001/tests/lib/mirrors...
File tests/lib/mirrors/library_declarations_test.dart (left):

https://chromiumcodereview.appspot.com/416873002/diff/40001/tests/lib/mirrors...
tests/lib/mirrors/library_declarations_test.dart:26: return;  /// 01: ok
\o/