sdk/lib/_internal/lib/js_mirrors.dart - Issue 416873002: Don't include class-static functions in library mirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 416873002: Don't include class-static functions in library mirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix typos. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart ('K') | « sdk/lib/_internal/lib/isolate_helper.dart ('k') | tests/lib/lib.status » ('j') | tests/lib/mirrors/library_declarations2_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/lib/js_mirrors.dart

diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart

index 912af14a257dfcc692e14c9b283ab7f93312b26d..b1a092077d36da1a5b73d004452714f194551903 100644

--- a/sdk/lib/_internal/lib/js_mirrors.dart

+++ b/sdk/lib/_internal/lib/js_mirrors.dart

@@ -426,12 +426,8 @@ class JsLibraryMirror extends JsDeclarationMirror with JsObjectMirror

// TODO(floitsch): Remove the getterStub hack.

continue;

}

- bool isConstructor = unmangledName.startsWith('new ');

- bool isStatic = !isConstructor; // Top-level functions are static, but

- // constructors are not.

- if (isConstructor) {

- unmangledName = unmangledName.substring(4).replaceAll(r'$', '.');

- }

+ bool isStatic = true;

+ bool isConstructor = false;

JsMethodMirror mirror =

new JsMethodMirror.fromUnmangledName(

unmangledName, jsFunction, isStatic, isConstructor);