scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json - Issue 412143008: Changes filter list to exclusion list

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json

Issue 412143008: Changes filter list to exclusion list (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: better comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json ('k') | scripts/slave/recipes/chromium_trybot.expected/swarming_basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "[BUILD]/scripts/slave/bot_update.py",	6 "[BUILD]/scripts/slave/bot_update.py",

7 "--master",	7 "--master",

8 "tryserver.chromium",	8 "tryserver.chromium",

9 "--builder",	9 "--builder",

10 "linux_chromium_rel",	10 "linux_chromium_rel",

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 "cmd": [	69 "cmd": [

70 "python",	70 "python",

71 "-u",	71 "-u",

72 "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",	72 "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

73 "[SLAVE_BUILD]/src/testing/buildbot/chromium_trybot.json",	73 "[SLAVE_BUILD]/src/testing/buildbot/chromium_trybot.json",

74 "/path/to/tmp/json"	74 "/path/to/tmp/json"

75 ],	75 ],

76 "name": "read test spec",	76 "name": "read test spec",

77 "~followup_annotations": [	77 "~followup_annotations": [

78 "@@@STEP_TEXT@path: testing/buildbot/chromium_trybot.json@@@",	78 "@@@STEP_TEXT@path: testing/buildbot/chromium_trybot.json@@@",

79 "@@@STEP_LOG_LINE@json.output@{@@@",	79 "@@@STEP_LOG_LINE@json.output@{}@@@",

80 "@@@STEP_LOG_LINE@json.output@ \"filter_builders\": [@@@",

81 "@@@STEP_LOG_LINE@json.output@ \"linux_chromium_rel\"@@@",

82 "@@@STEP_LOG_LINE@json.output@ ]@@@",

83 "@@@STEP_LOG_LINE@json.output@}@@@",

84 "@@@STEP_LOG_END@json.output@@@"	80 "@@@STEP_LOG_END@json.output@@@"

85 ]	81 ]

86 },	82 },

87 {	83 {

88 "cmd": [	84 "cmd": [

89 "git",	85 "git",

90 "diff",	86 "diff",

91 "--cached",	87 "--cached",

92 "--name-only"	88 "--name-only"

93 ],	89 ],

94 "cwd": "[SLAVE_BUILD]/src",	90 "cwd": "[SLAVE_BUILD]/src",

95 "name": "git diff to analyze patch",	91 "name": "git diff to analyze patch",

96 "stdout": "/path/to/tmp/"	92 "stdout": "/path/to/tmp/"

97 },	93 },

98 {	94 {

99 "cmd": [	95 "cmd": [

100 "python",	96 "python",

101 "-u",	97 "-u",

102 "[SLAVE_BUILD]/src/build/gyp_chromium",	98 "[SLAVE_BUILD]/src/build/gyp_chromium",

103 "--analyzer",	99 "--analyzer",

104 "foo.cc"	100 "foo.cc"

105 ],	101 ],

106 "name": "analyze",	102 "name": "analyze",

107 "stdout": "/path/to/tmp/",	103 "stdout": "/path/to/tmp/",

108 "~followup_annotations": [	104 "~followup_annotations": [

109 "@@@STEP_TEXT@No compile necessary@@@"	105 "@@@STEP_TEXT@No compile necessary@@@"

110 ]	106 ]

111 }	107 }

112 ]	108 ]

OLD	NEW