Changes filter list to exclusion list

Changes filter list to exclusion list

This effectively turns on filtering for all trybots with the ability
to turn it off for those that don't want it.

BUG=383609
TEST=covered by tests
R=iannucci@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=285349

[iannucci, 2014-07-24 19:08:11]

lgtm

https://chromiumcodereview.appspot.com/412143008/diff/20001/scripts/slave/rec...
File scripts/slave/recipes/chromium_trybot.py (right):

https://chromiumcodereview.appspot.com/412143008/diff/20001/scripts/slave/rec...
scripts/slave/recipes/chromium_trybot.py:5: import re
general disclaimer: imports in recipes are usually dangerous because they might
have platform-specific behavior (leading to non-deterministic test
expectations). Importing 'sys' or 'os' would mean certain doom. Others like
tempfile are non-obviously doomful too.

re happens to be one of the good ones though.

I'm pretty sure you knew all that, but I felt like I had to say it anyway :p

In the future, we'll probably be locking down what system modules are importable
in recipes with a proper error message, but right now it's just code-review
vigilance.

https://chromiumcodereview.appspot.com/412143008/diff/20001/scripts/slave/rec...
scripts/slave/recipes/chromium_trybot.py:748: 'non_filter_builders': ['.*'],
you may want to consider fnmatch instead of regex. It's a bit more user friendly
and should be powerful enough for this purpose.

[sky, 2014-07-24 19:15:30]

https://chromiumcodereview.appspot.com/412143008/diff/20001/scripts/slave/rec...
File scripts/slave/recipes/chromium_trybot.py (right):

https://chromiumcodereview.appspot.com/412143008/diff/20001/scripts/slave/rec...
scripts/slave/recipes/chromium_trybot.py:5: import re
On 2014/07/24 19:08:10, iannucci wrote:
> general disclaimer: imports in recipes are usually dangerous because they
might
> have platform-specific behavior (leading to non-deterministic test
> expectations). Importing 'sys' or 'os' would mean certain doom. Others like
> tempfile are non-obviously doomful too.
> 
> re happens to be one of the good ones though.
> 
> I'm pretty sure you knew all that, but I felt like I had to say it anyway :p
> 
> In the future, we'll probably be locking down what system modules are
importable
> in recipes with a proper error message, but right now it's just code-review
> vigilance.

Good to know. Thanks!

https://chromiumcodereview.appspot.com/412143008/diff/20001/scripts/slave/rec...
scripts/slave/recipes/chromium_trybot.py:748: 'non_filter_builders': ['.*'],
On 2014/07/24 19:08:10, iannucci wrote:
> you may want to consider fnmatch instead of regex. It's a bit more user
friendly
> and should be powerful enough for this purpose.

I don't feel strongly as to which is more widely known. I'm going to leave it as
a regular expression for now.

[sky, 2014-07-24 19:17:09]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-07-24 19:17:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/412143008/20001

[commit-bot: I haz the power, 2014-07-24 19:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 19:18:36]

Presubmit check for 412143008-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
scripts/slave/unittests/recipe_simulation_test.py (16.56s) failed
..............................................................................................................................................................................................................................................................................................................................................E...................................................................................................................................................................................................................................................................................................

======================================================================
ERROR: chromium_trybot.check_swarming_version_failure
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/check_swarming_version_failure.json)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 167, in generate_tests_results
    for subtest, subresult in test.process(process_test):
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/type_definitions.py",
line 230, in process
    yield self, func(self.bind(context=None))
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 144, in process_test
    subresult = subtest.run()
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/type_definitions.py",
line 219, in run
    return self.func_call(context=context)
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/type_definitions.py",
line 145, in __call__
    return f.func(*f.args, **f.kwargs)
  File "scripts/slave/unittests/recipe_simulation_test.py", line 28, in
RunRecipe
    test_data.properties, test_data)
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/annotated_run.py",
line 473, in run_steps
    return engine.unhandled_exception()
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/annotated_run.py",
line 471, in run_steps
    return engine.run(steps)
  File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/annotated_run.py",
line 624, in run
    "Unconsumed test data! %s" % (self._test_data.step_data,))
AssertionError: Unconsumed test data! defaultdict(<class
'slave.recipe_test_api.StepTestData'>, {'swarming.py --version':
StepTestData({'override': False, 'placeholder_data': {}, 'retcode': 1, 'stderr':
None, 'stdout': None})})



----------------------------------------------------------------------
Ran 626 tests in 14.220s

FAILED (errors=1)


Presubmit checks took 55.0s to calculate.

[sky, 2014-07-24 19:23:55]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-07-24 19:24:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/412143008/40001

[commit-bot: I haz the power, 2014-07-24 19:25:39]

Change committed as 285349