Closure compilation config: switch from JSON to Python dict

Closure compilation config: switch from JSON to Python dict

BUG=78368
R=dbeam@chromium.org

[Dan Beam, 2014-07-23 22:00:59]

i wouldn't name it .py, that seems like it'll be executed or used as python. 
it's more just a dictionary.  maybe compiled.resources or something like this?

[Vitaly Pavlenko, 2014-07-23 22:04:51]

On 2014/07/23 22:00:59, Dan Beam wrote:
> i wouldn't name it .py, that seems like it'll be executed or used as python. 
> it's more just a dictionary.  maybe compiled.resources or something like this?

I just like the .py extension, because this way the editors highlight it
correctly and give a way to comment multiple lines with standard hotkeys. if we
want to keep this perk, we may add a top comment like
# This is just a config dictionary.  Running this file makes no effect.

[Dan Beam, 2014-07-23 22:35:42]

On 2014/07/23 22:04:51, Vitaly Pavlenko wrote:
> On 2014/07/23 22:00:59, Dan Beam wrote:
> > i wouldn't name it .py, that seems like it'll be executed or used as python.

> > it's more just a dictionary.  maybe compiled.resources or something like
this?
> 
> I just like the .py extension, because this way the editors highlight it
> correctly and give a way to comment multiple lines with standard hotkeys. if
we
> want to keep this perk, we may add a top comment like
> # This is just a config dictionary.  Running this file makes no effect.

https://code.google.com/p/chromium/codesearch#chromium/tools/build/masters/ma...

[Dan Beam, 2014-07-24 03:52:25]

btw, publish a message when you're ready for me to re-review (don't know if you
were or not in this case)

https://chromiumcodereview.appspot.com/410333002/diff/10001/third_party/closu...
File third_party/closure_compiler/compile_modules.py (right):

https://chromiumcodereview.appspot.com/410333002/diff/10001/third_party/closu...
third_party/closure_compiler/compile_modules.py:58: pretty_json =
json.dumps(data, indent=2, separators=(',', ': ')).strip()
i think we should just read the file and print it rather than pretty print it.

this is what other scripts do and it doesn't re-arrange the file.

this would also allow us to remove dependencies on json/simplejson.

[Vitaly Pavlenko, 2014-07-24 18:32:02]

https://chromiumcodereview.appspot.com/410333002/diff/10001/third_party/closu...
File third_party/closure_compiler/compile_modules.py (right):

https://chromiumcodereview.appspot.com/410333002/diff/10001/third_party/closu...
third_party/closure_compiler/compile_modules.py:58: pretty_json =
json.dumps(data, indent=2, separators=(',', ': ')).strip()
On 2014/07/24 03:52:25, Dan Beam wrote:
> i think we should just read the file and print it rather than pretty print it.
> 
> this is what other scripts do and it doesn't re-arrange the file.
> 
> this would also allow us to remove dependencies on json/simplejson.

Acknowledged.

[Dan Beam, 2014-07-24 18:34:42]

lgtm but we need to add compiled_resources.json before your patch will work
(right now it's based on files that don't exist yet)

https://chromiumcodereview.appspot.com/410333002/diff/30001/third_party/closu...
File third_party/closure_compiler/compile_modules.py (right):

https://chromiumcodereview.appspot.com/410333002/diff/30001/third_party/closu...
third_party/closure_compiler/compile_modules.py:49: file_content = file.read()
nit: file_contents = open(file_path, "r").read()

[Vitaly Pavlenko, 2014-07-25 22:09:22]

https://chromiumcodereview.appspot.com/410333002/diff/30001/third_party/closu...
File third_party/closure_compiler/compile_modules.py (right):

https://chromiumcodereview.appspot.com/410333002/diff/30001/third_party/closu...
third_party/closure_compiler/compile_modules.py:49: file_content = file.read()
On 2014/07/24 18:34:42, Dan Beam wrote:
> nit: file_contents = open(file_path, "r").read()

I think that's better:
with open(file_path) as file:
  file_contents = file.read()

I mean, it's unspecified when the opened file should be closed in your case. Of
course, that's not a problem for small scripts, but I could think the general
trend in guides about that should be like I said. What do you think?

[Dan Beam, 2014-08-18 21:18:59]

i would drop this CL