Closure compilation config: switch from JSON to Python dict

third_party/closure_compiler/compile_modules.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
+import ast
 from checker import Checker as Checker
 import os
 try:
   import json
 except:
   import simplejson as json
 
 
 
 class Module(object):
@@ skipping 26 matching lines @@
 
   def __init__(self, verbose=False):
     self._verbose = verbose
 
   def parse(self, file_path):
     if file_path in self._cache:
       print "(INFO) Found module file %s in the cache" % file_path
       return self._cache[file_path]
 
     file = open(file_path, "r")
-    data = json.load(file)
+    data = ast.literal_eval(file.read())
     file.close()
 
     if self._verbose:
       pretty_json = json.dumps(data, indent=2, separators=(',', ': ')).strip()

[Dan Beam, 2014/07/24 03:52:25]

i think we should just read the file and print it rather than pretty print it.

this is what other scripts do and it doesn't re-arrange the file.

this would also allow us to remove dependencies on json/simplejson.

[Vitaly Pavlenko, 2014/07/24 18:32:02]

Acknowledged.

       print "(INFO) Layout: " + os.linesep + pretty_json + os.linesep
 
     self._cache[file_path] = [Module.from_dict(m) for m in data]
     return self._cache[file_path]
 
 
 class ModuleCompiler(object):
   _checker = None
   _parser = None
 
@@ skipping 46 matching lines @@
 
 
 if __name__ == "__main__":
   parser = argparse.ArgumentParser(
       description="Typecheck JavaScript using Closure compiler")
   parser.add_argument("-v", "--verbose", action="store_true",
                       help="Show more information as this script runs")
   parser.add_argument("module_file", nargs=argparse.ONE_OR_MORE,
                       help="Path to a modules file to check")
   main(parser.parse_args())