Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4272)

Unified Diff: chrome/browser/resources/options/language_add_language_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_add_language_overlay.js
diff --git a/chrome/browser/resources/options/language_add_language_overlay.js b/chrome/browser/resources/options/language_add_language_overlay.js
index f91d170922cf8056586088df4d11698a325e6bd1..6f3bb5518b4f013e664e7dfe50c2ea0237e8ff39 100644
--- a/chrome/browser/resources/options/language_add_language_overlay.js
+++ b/chrome/browser/resources/options/language_add_language_overlay.js
@@ -6,35 +6,34 @@
// AddLanguageOverlay class:
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/**
* Encapsulated handling of ChromeOS add language overlay page.
* @constructor
*/
function AddLanguageOverlay() {
- OptionsPage.call(this, 'addLanguage',
- loadTimeData.getString('addButton'),
- 'add-language-overlay-page');
+ Page.call(this, 'addLanguage',
+ loadTimeData.getString('addButton'),
+ 'add-language-overlay-page');
}
cr.addSingletonGetter(AddLanguageOverlay);
AddLanguageOverlay.prototype = {
- // Inherit AddLanguageOverlay from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit AddLanguageOverlay from Page.
+ __proto__: Page.prototype,
/**
* Initializes AddLanguageOverlay page.
- * Calls base class implementation to starts preference initialization.
*/
initializePage: function() {
- // Call base class implementation to starts preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
// Set up the cancel button.
$('add-language-overlay-cancel-button').onclick = function(e) {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
// Create the language list with which users can add a language.

Powered by Google App Engine
This is Rietveld 408576698