Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2592)

Unified Diff: chrome/browser/resources/options/hotword_confirm_dialog.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/hotword_confirm_dialog.js
diff --git a/chrome/browser/resources/options/hotword_confirm_dialog.js b/chrome/browser/resources/options/hotword_confirm_dialog.js
index c32b77287edd8947815fa48a424c669b1e82e815..c759540ecafdae8750cf53065808e1842fe1bd9c 100644
--- a/chrome/browser/resources/options/hotword_confirm_dialog.js
+++ b/chrome/browser/resources/options/hotword_confirm_dialog.js
@@ -5,7 +5,7 @@
cr.define('options', function() {
/** @const */ var ConfirmDialog = options.ConfirmDialog;
/** @const */ var SettingsDialog = options.SettingsDialog;
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/**
* A dialog that will pop up when the user attempts to set the value of the
@@ -48,7 +48,7 @@ cr.define('options', function() {
if (event.value.value && !this.confirmed_) {
if (!this.indicator.errorText) {
- OptionsPage.showPageByName(this.name, false);
+ PageManager.showPageByName(this.name, false);
} else {
this.indicator.updateBasedOnError();
this.handleCancel();

Powered by Google App Engine
This is Rietveld 408576698