Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: chrome/browser/resources/options/controlled_setting.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/controlled_setting.js
diff --git a/chrome/browser/resources/options/controlled_setting.js b/chrome/browser/resources/options/controlled_setting.js
index 5ac42d971e428a45e75e5d08e78c54461eae5b93..fae26402ebd0091617284e44e07d56b844ef46a1 100644
--- a/chrome/browser/resources/options/controlled_setting.js
+++ b/chrome/browser/resources/options/controlled_setting.js
@@ -56,7 +56,7 @@ cr.define('options', function() {
* @param {Event} event Pref change event.
*/
handlePrefChange: function(event) {
- OptionsPage.hideBubble();
+ PageManager.hideBubble();
if (event.value.controlledBy) {
if (!this.value || String(event.value.value) == this.value) {
this.controlledBy = event.value.controlledBy;
@@ -83,7 +83,7 @@ cr.define('options', function() {
*/
toggleBubble_: function() {
if (this.showingBubble) {
- OptionsPage.hideBubble();
+ PageManager.hideBubble();
} else {
var self = this;
@@ -179,7 +179,7 @@ cr.define('options', function() {
content.appendChild(extensionContainer);
}
- OptionsPage.showBubble(content, this.image, this, this.location);
+ PageManager.showBubble(content, this.image, this, this.location);
}
},
};

Powered by Google App Engine
This is Rietveld 408576698