Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/resources/options/certificate_manager.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/certificate_manager.js
diff --git a/chrome/browser/resources/options/certificate_manager.js b/chrome/browser/resources/options/certificate_manager.js
index b2d46e9dc0c0dfe13cce65236e96e2c79fd68a35..27026c193831d27fdcc2fdf6110fe704d0cae122 100644
--- a/chrome/browser/resources/options/certificate_manager.js
+++ b/chrome/browser/resources/options/certificate_manager.js
@@ -4,6 +4,8 @@
cr.define('options', function() {
var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/////////////////////////////////////////////////////////////////////////////
// CertificateManagerTab class:
@@ -171,18 +173,18 @@ cr.define('options', function() {
* @constructor
*/
function CertificateManager(model) {
- OptionsPage.call(this, 'certificates',
- loadTimeData.getString('certificateManagerPageTabTitle'),
- 'certificateManagerPage');
+ Page.call(this, 'certificates',
+ loadTimeData.getString('certificateManagerPageTabTitle'),
+ 'certificateManagerPage');
}
cr.addSingletonGetter(CertificateManager);
CertificateManager.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
initializePage: function(isKiosk) {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
this.personalTab = new CertificateManagerTab('personalCertsTab',
!!isKiosk);
@@ -193,14 +195,14 @@ cr.define('options', function() {
this.addEventListener('visibleChange', this.handleVisibleChange_);
$('certificate-confirm').onclick = function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
},
initalized_: false,
/**
- * Handler for OptionsPage's visible property change event.
+ * Handler for Page's visible property change event.
* @private
* @param {Event} e Property change event.
*/

Powered by Google App Engine
This is Rietveld 408576698