Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2159)

Unified Diff: chrome/browser/resources/options/certificate_import_error_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/certificate_import_error_overlay.js
diff --git a/chrome/browser/resources/options/certificate_import_error_overlay.js b/chrome/browser/resources/options/certificate_import_error_overlay.js
index 4eed1d25d5739106cc8b3b52749b17d43dfff510..7ffefefd1c639282f6f1ad6b1ab01d109e9b40f3 100644
--- a/chrome/browser/resources/options/certificate_import_error_overlay.js
+++ b/chrome/browser/resources/options/certificate_import_error_overlay.js
@@ -4,7 +4,8 @@
cr.define('options', function() {
Dan Beam 2014/07/30 01:00:01 nit: remove \n
michaelpg 2014/07/30 21:42:19 Done.
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* CertificateImportErrorOverlay class
@@ -12,25 +13,24 @@ cr.define('options', function() {
* @class
*/
function CertificateImportErrorOverlay() {
- OptionsPage.call(this, 'certificateImportErrorOverlay', '',
- 'certificateImportErrorOverlay');
+ Page.call(this, 'certificateImportErrorOverlay', '',
+ 'certificateImportErrorOverlay');
}
cr.addSingletonGetter(CertificateImportErrorOverlay);
CertificateImportErrorOverlay.prototype = {
- // Inherit CertificateImportErrorOverlay from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit CertificateImportErrorOverlay from Page.
+ __proto__: Page.prototype,
/**
* Initialize the page.
*/
initializePage: function() {
- // Call base class implementation to start preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
$('certificateImportErrorOverlayOk').onclick = function(event) {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
},
};
@@ -57,7 +57,7 @@ cr.define('options', function() {
ul.appendChild(li);
}
- OptionsPage.navigateToPage('certificateImportErrorOverlay');
+ PageManager.showPageByName('certificateImportErrorOverlay');
}
// Export

Powered by Google App Engine
This is Rietveld 408576698