Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index 62e8aa00059596b667fd1820b1d71b3a8d8b6406..675499e1d3e8aad5479f89cf98f4ca0e2a573993 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -277,13 +277,12 @@ WebInspector.ConsoleViewMessage.prototype = {
{
console.assert(this._linkifier);
var target = this._target();
- if (!this._linkifier || !target)
+ if (!this._linkifier)
return null;
// FIXME(62725): stack trace line/column numbers are one-based.
var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
- var rawLocation = new WebInspector.DebuggerModel.Location(target, callFrame.scriptId, lineNumber, columnNumber);
- return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");
+ return this._linkifier.linkifyLocationByScriptId(target, callFrame.scriptId, callFrame.url, lineNumber, columnNumber, "console-message-url");
},
/**

Powered by Google App Engine
This is Rietveld 408576698