Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/ObjectPopoverHelper.js
diff --git a/Source/devtools/front_end/components/ObjectPopoverHelper.js b/Source/devtools/front_end/components/ObjectPopoverHelper.js
index 274229c35c0f3a7e5321f4536e655018d6a864c4..9926149ad1a07c908b8fad57ffe329a727470b84 100644
--- a/Source/devtools/front_end/components/ObjectPopoverHelper.js
+++ b/Source/devtools/front_end/components/ObjectPopoverHelper.js
@@ -81,16 +81,14 @@ WebInspector.ObjectPopoverHelper.prototype = {
functionName.textContent = response.functionName || WebInspector.UIString("(anonymous function)");
var rawLocation = response.location;
- var link;
- if (rawLocation) {
+ var sourceURL = response.sourceURL;
+ if (rawLocation && sourceURL) {
this._linkifier = new WebInspector.Linkifier();
- link = this._linkifier.linkifyRawLocation(rawLocation, "function-location-link");
- }
- if (link)
+ var link = this._linkifier.linkifyLocationByScriptId(target, rawLocation.scriptId, sourceURL, rawLocation.lineNumber, rawLocation.columnNumber, "function-location-link");
title.appendChild(link);
+ }
container.appendChild(popoverContentElement);
-
popover.show(container, anchorElement);
}
« no previous file with comments | « no previous file | Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | Source/devtools/front_end/sdk/Linkifier.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698