Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 400183002: Convenience script for fetching dartium (Closed)

Created:
6 years, 5 months ago by vsm
Modified:
6 years, 4 months ago
Reviewers:
terry, rmacnak
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Convenience script for fetching dartium R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=38672

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -0 lines) Patch
A tools/dartium/fetch_dartium.py View 1 1 chunk +142 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsm
6 years, 5 months ago (2014-07-18 12:47:47 UTC) #1
vsm
On 2014/07/18 12:47:47, vsm wrote: I've been using this to easily checkout writable git-svn-based copies ...
6 years, 5 months ago (2014-07-18 12:52:19 UTC) #2
terry
lgtm Worked except for --path with ~. Had to use fully qualified path see suggestion. ...
6 years, 5 months ago (2014-07-18 13:33:03 UTC) #3
rmacnak
https://codereview.chromium.org/400183002/diff/1/tools/dartium/fetch_dartium.py File tools/dartium/fetch_dartium.py (right): https://codereview.chromium.org/400183002/diff/1/tools/dartium/fetch_dartium.py#newcode106 tools/dartium/fetch_dartium.py:106: blink_fetch = Run(['git', 'svn', 'clone', '-rHEAD', blink_url, 'blink']) These ...
6 years, 5 months ago (2014-07-18 18:27:16 UTC) #4
vsm
https://chromiumcodereview.appspot.com/400183002/diff/1/tools/dartium/fetch_dartium.py File tools/dartium/fetch_dartium.py (right): https://chromiumcodereview.appspot.com/400183002/diff/1/tools/dartium/fetch_dartium.py#newcode59 tools/dartium/fetch_dartium.py:59: path = options.path On 2014/07/18 13:33:03, terry wrote: > ...
6 years, 4 months ago (2014-07-29 14:48:42 UTC) #5
vsm
6 years, 4 months ago (2014-07-29 14:59:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r38672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698