Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: chrome/common/pref_names.cc

Issue 393023006: Add settings for keyboard auto-repeat to options page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/pref_names.cc
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index 7578e37f1f4b4958bb83aaae11c922d3b4035fce..1eb045be04d042f37ee1c18778e77d1578bee049 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -566,8 +566,10 @@ const char kLanguageXkbAutoRepeatDelay[] =
// A integer pref which determines key repeat interval (in ms).
const char kLanguageXkbAutoRepeatInterval[] =
"settings.language.xkb_auto_repeat_interval_r2";
-// "_r2" suffixes are added to the three prefs above when we change the
-// preferences not user-configurable, not to sync them with cloud.
+// "_r2" suffixes were added to the three prefs above when we changed the
+// preferences to not be user-configurable or sync with cloud. The prefs are
Dan Beam 2014/07/16 16:59:46 sync with the cloud?
michaelpg 2014/07/18 21:33:06 Done.
+// now user-configurable and syncable again, but we don't want to overwrite the
+// current values with the old synced values, so we continue to use this suffix.
michaelpg 2014/07/16 01:51:24 Would it be better to change the preference names
Dan Beam 2014/07/16 16:59:46 not sure. if we're not losing any loser data by k
stevenjb 2014/07/16 17:41:46 I would use the current _r2 names so that users do
michaelpg 2014/07/18 21:33:06 Acknowledged.
// A boolean pref which determines whether the large cursor feature is enabled.
const char kAccessibilityLargeCursorEnabled[] =

Powered by Google App Engine
This is Rietveld 408576698