Add settings for keyboard auto-repeat to options page.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
 namespace prefs {
@@ skipping 548 matching lines @@
 
 // A boolean pref which determines whether key repeat is enabled.
 const char kLanguageXkbAutoRepeatEnabled[] =
     "settings.language.xkb_auto_repeat_enabled_r2";
 // A integer pref which determines key repeat delay (in ms).
 const char kLanguageXkbAutoRepeatDelay[] =
     "settings.language.xkb_auto_repeat_delay_r2";
 // A integer pref which determines key repeat interval (in ms).
 const char kLanguageXkbAutoRepeatInterval[] =
     "settings.language.xkb_auto_repeat_interval_r2";
-// "_r2" suffixes are added to the three prefs above when we change the
-// preferences not user-configurable, not to sync them with cloud.
+// "_r2" suffixes were added to the three prefs above when we changed the
+// preferences to not be user-configurable or sync with cloud. The prefs are

[Dan Beam, 2014/07/16 16:59:46]

sync with the cloud?

[michaelpg, 2014/07/18 21:33:06]

Done.

+// now user-configurable and syncable again, but we don't want to overwrite the
+// current values with the old synced values, so we continue to use this suffix.

[michaelpg, 2014/07/16 01:51:24]

Would it be better to change the preference names again? :-\

[Dan Beam, 2014/07/16 16:59:46]

not sure.  if we're not losing any loser data by keeping the same name, i guess
it's worth considering.

[stevenjb, 2014/07/16 17:41:46]

I would use the current _r2 names so that users do not have any existing
settings changed unexpectedly.

[michaelpg, 2014/07/18 21:33:06]

Acknowledged.
;-)

 
 // A boolean pref which determines whether the large cursor feature is enabled.
 const char kAccessibilityLargeCursorEnabled[] =
     "settings.a11y.large_cursor_enabled";
 
 // A boolean pref which determines whether the sticky keys feature is enabled.
 const char kAccessibilityStickyKeysEnabled[] =
     "settings.a11y.sticky_keys_enabled";
 // A boolean pref which determines whether spoken feedback is enabled.
 const char kAccessibilitySpokenFeedbackEnabled[] = "settings.accessibility";
@@ skipping 1705 matching lines @@
 // "mapped_title" entries, detailing the bookmark target URL (if any), the title
 // given by the PartnerBookmarksProvider and either the user-visible renamed
 // title or an empty string if the bookmark node was removed.
 const char kPartnerBookmarkMappings[] = "partnerbookmarks.mappings";
 #endif
 
 // Whether DNS Quick Check is disabled in proxy resolution.
 const char kQuickCheckEnabled[] = "proxy.quick_check_enabled";
 
 }  // namespace prefs