Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2071)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392223002: Added logging to the status_json.py (Closed)

Created:
6 years, 5 months ago by Sergiy Byelozyorov
Modified:
6 years, 5 months ago
Reviewers:
agable
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added diff to the README.chromium #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Updated README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M third_party/buildbot_8_4p1/README.chromium View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/status_json.py View 1 2 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergiy Byelozyorov
6 years, 5 months ago (2014-07-16 09:52:34 UTC) #1
agable
https://codereview.chromium.org/392223002/diff/20001/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py File third_party/buildbot_8_4p1/buildbot/status/web/status_json.py (right): https://codereview.chromium.org/392223002/diff/20001/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py#newcode167 third_party/buildbot_8_4p1/buildbot/status/web/status_json.py:167: print 'Received request for %s from %s, id: %s' ...
6 years, 5 months ago (2014-07-16 16:39:21 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/392223002/diff/20001/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py File third_party/buildbot_8_4p1/buildbot/status/web/status_json.py (right): https://codereview.chromium.org/392223002/diff/20001/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py#newcode167 third_party/buildbot_8_4p1/buildbot/status/web/status_json.py:167: print 'Received request for %s from %s, id: %s' ...
6 years, 5 months ago (2014-07-17 08:29:12 UTC) #3
agable
LGTM
6 years, 5 months ago (2014-07-17 15:24:14 UTC) #4
Sergiy Byelozyorov
The CQ bit was checked by sergiyb@chromium.org
6 years, 5 months ago (2014-07-17 16:29:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/392223002/60001
6 years, 5 months ago (2014-07-17 16:29:16 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 16:31:26 UTC) #7
Message was sent while issue was closed. 
Change committed as 283793

Powered by Google App Engine
This is Rietveld 408576698