Issue 390853002: DevTools: fixed compilation problem with InjectedScriptSource.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390853002: DevTools: fixed compilation problem with InjectedScriptSource.js (Closed)

Created:
6 years, 5 months ago by kozyatinskiy1

Modified:
6 years, 5 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Added declarations to InjectedScriptExterns: JavaScriptCallFrame.prototype.evaluateWithExceptionDetails = function(expression) { } InjectedScriptHostClass.prototype.eval = function(expression) InjectedScriptHostClass.prototype.evaluateWithExceptionDetails = function(expression) { } These methods was added in https://codereview.chromium.org/289423002/ NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178059

Patch Set 1 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	Source/core/inspector/InjectedScriptExterns.js	View		2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kozyatinskiy1

Compilation problem fixed. Added InjectedScriptExterns declarations.

6 years, 5 months ago (2014-07-14 14:18:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/390853002/20001

6 years, 5 months ago (2014-07-14 14:34:56 UTC) #3

vsevik

6 years, 5 months ago (2014-07-14 16:27:57 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://chromiumcodereview.appspot.com/388253005/ by vsevik@chromium.org.

The reason for reverting is: The original patch that was fixed by this one was
reverted..

Expand Messages | Collapse Messages