Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 388253005: Revert of DevTools: fixed compilation problem with InjectedScriptSource.js (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
kozyatinskiy1, pfeldman
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: fixed compilation problem with InjectedScriptSource.js (https://chromiumcodereview.appspot.com/390853002/) Reason for revert: The original patch that was fixed by this one was reverted. Original issue's description: > Added declarations to InjectedScriptExterns: > JavaScriptCallFrame.prototype.evaluateWithExceptionDetails = function(expression) { } > InjectedScriptHostClass.prototype.eval = function(expression) > InjectedScriptHostClass.prototype.evaluateWithExceptionDetails = function(expression) { } > These methods was added in https://codereview.chromium.org/289423002/ > > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178059 TBR=pfeldman@chromium.org,kozyatinskiy@google.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M Source/core/inspector/InjectedScriptExterns.js View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
Created Revert of DevTools: fixed compilation problem with InjectedScriptSource.js
6 years, 5 months ago (2014-07-14 16:27:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/388253005/1
6 years, 5 months ago (2014-07-14 16:28:57 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 16:29:20 UTC) #3
Message was sent while issue was closed.
Change committed as 178074

Powered by Google App Engine
This is Rietveld 408576698