Issue 380001: Re-enable ToastCrasher test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 380001: Re-enable ToastCrasher test (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
8 years, 5 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-enabling the TryChromeDialogBrowserTest.ToastCrasher crash, as the underlying cause that made the test fail seems to be gone. Also added a comment. BUG=127396 TEST=None, enabling a test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148539

Patch Set 1 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc	View		1 chunk	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

As indicated in the left column in Rietveld, it has been almost three years since ...

8 years, 5 months ago (2012-07-25 15:53:39 UTC) #1

cpu_(ooo_6.6-7.5)

8 years, 5 months ago (2012-07-25 19:17:08 UTC) #2

It was a dark and stormy night. The tree howled and CLs and reverts scuffled and
rattled past the irc log. Mr and Mrs Pizano sat in the parlour of their cosy
home, in front of a blazing chromebook. Mr Pizano played chess with his
automaton, Herbert. His wife sat in a rocking chair knitting and watching
youtubes in her ipad. Then Mr Pizano realized that he never saw finnur's change.
When he finally did he said:

lgtm

Expand Messages | Collapse Messages