Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc

Issue 380001: Re-enable ToastCrasher test (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/common/chrome_switches.h" 6 #include "chrome/common/chrome_switches.h"
7 #include "chrome/test/base/in_process_browser_test.h" 7 #include "chrome/test/base/in_process_browser_test.h"
8 8
9 // Unfortunately, this needs to be Windows only for now. Even though this test 9 // Unfortunately, this needs to be Windows only for now. Even though this test
10 // is meant to exercise code that is for Windows only, it is a good general 10 // is meant to exercise code that is for Windows only, it is a good general
(...skipping 13 matching lines...) Expand all
24 class TryChromeDialogBrowserTest : public InProcessBrowserTest { 24 class TryChromeDialogBrowserTest : public InProcessBrowserTest {
25 public: 25 public:
26 TryChromeDialogBrowserTest() {} 26 TryChromeDialogBrowserTest() {}
27 27
28 protected: 28 protected:
29 virtual void SetUpCommandLine(CommandLine* command_line) { 29 virtual void SetUpCommandLine(CommandLine* command_line) {
30 command_line->AppendSwitchASCII(switches::kTryChromeAgain, "10001"); 30 command_line->AppendSwitchASCII(switches::kTryChromeAgain, "10001");
31 } 31 }
32 }; 32 };
33 33
34 // Marking test TryChromeDialogBrowserTest.ToastCrasher DISABLED since its 34 // Note to Sheriffs: This test (as you can read about above) simply causes
35 // breaking the win_rel CQ bot. crbug.com/127396 35 // Chrome to shutdown early, and, as such, has proven to be pretty good at
36 IN_PROC_BROWSER_TEST_F(TryChromeDialogBrowserTest, DISABLED_ToastCrasher) {} 36 // finding problems related to shutdown. Sheriff, before marking this test as
37 // disabled, please consider that this test is meant to catch when people
38 // introduce changes that crash Chrome during shutdown and disabling this test
39 // and moving on removes a safeguard meant to avoid an even bigger thorny mess
40 // to untangle much later down the line. Disabling the test also means that the
41 // people who get blamed are not the ones that introduced the crash (in other
42 // words, don't shoot the messenger). So, please help us avoid additional
43 // shutdown crashes from creeping in, by doing the following:
44 // Run chrome.exe --try-chrome-again=10001. This is all that the test does and
45 // should be enough to trigger the failure. If it is a crash (most likely) then
46 // look at the callstack and see if any of the components have been touched
47 // recently. Look at recent changes to startup, such as any change to
48 // ChromeBrowserMainParts, specifically PreCreateThreadsImpl and see if someone
49 // has been reordering code blocks for startup. Try reverting any suspicious
50 // changes to see if it affects the test. History shows that waiting until later
51 // only makes the problem worse.
52 IN_PROC_BROWSER_TEST_F(TryChromeDialogBrowserTest, ToastCrasher) {}
37 53
38 #endif // defined(OS_WIN) 54 #endif // defined(OS_WIN)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698