[WIP] Make extension APIs work in devtools APIs when docked.

[WIP] Make extension APIs work in devtools APIs when docked.

This doesn't work.

BUG=178618

[not at google - send to devlin, 2014-07-09 18:17:54]

I've tried a bunch of things here and nothing is working. Any chance either of
you can point me in the right direction?

[not at google - send to devlin, 2014-07-09 18:18:45]

https://codereview.chromium.org/379963002/diff/1/extensions/browser/extension...
File extensions/browser/extension_function_dispatcher.cc (right):

https://codereview.chromium.org/379963002/diff/1/extensions/browser/extension...
extensions/browser/extension_function_dispatcher.cc:296: LOG(INFO) <<
"Dispatched " << params.name;
calls are never reaching here.

[dgozman, 2014-07-09 20:13:36]

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:593:
main_web_contents_->SetDelegate(this);
The main difference between docked and undocked DevTools is in helpers attached
by browser (TabHelpers::AttachTabHelpers).

My guess is that you need
|extensions::TabHelper::CreateForWebContents(web_contents)| call from there.
If you need to attach a helper, you should do it here.

Not sure why anybody needs to change localStorage of DevTools from extension. Is
that safe? Changing something in DevTools may affect the page it inspects, for
example privileged WebUI page.

[pfeldman, 2014-07-10 13:44:36]

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:519:
content::WebContents::FromRenderViewHost(inspected_rvh);
I don't think inspected page contents should be involved in this scenario. All
you want is the main devtools web contents, right? DevToolsUIBindings is created
around it.

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:593:
main_web_contents_->SetDelegate(this);
It seems like ExtensionHostMsg_Request is dispatched in
TabHelper::OnMessageReceived which is missing. I wonder if it should move into
extensions::ChromeExtensionWebContentsObserver (along with other
extension-related methods?).

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:852:
extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
I don't think you want to do this here. Wiring the main web contents should be
sufficient.

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:870:
extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
ditto.

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.cc:897: LOG(INFO) << "web contents
created on " << target_url;
ditto.

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_window.h (right):

https://codereview.chromium.org/379963002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_window.h:34: public
extensions::ExtensionFunctionDispatcher::Delegate {
You probably want to add this aspect to DevToolsUIBindings, not the
DevToolsWindow.

[pfeldman, 2015-05-15 23:40:36]

pfeldman@chromium.org changed reviewers:
- pfeldman@chromium.org

[dgozman, 2015-06-30 14:25:12]

dgozman@chromium.org changed reviewers:
- dgozman@chromium.org