Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: content/browser/frame_host/navigator.h

Issue 379143002: PlzNavigate: implement RequestNavigation in the no live renderer case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Charlie's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 39345f47e4950110ca947a5c911ab90c6ffbec41..25026d8e5e70ab3f9a518bbe119e31b72846bb1b 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -37,7 +37,6 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
// Returns the NavigationController associated with this Navigator.
virtual NavigationController* GetController();
-
// Notifications coming from the RenderFrameHosts ----------------------------
// The RenderFrameHostImpl started a provisional load.
@@ -119,6 +118,12 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
bool should_replace_current_entry,
bool user_gesture) {}
+ // Will crash the browser if |render_frame_host| is a Web-UI renderer that
+ // tries to display a non Web UI |url|.
+ virtual void CheckWebUIRendererDoesNotDisplayNormalURL(
Charlie Reis 2014/08/05 23:59:51 This is really a private helper function. We shou
+ RenderFrameHostImpl* render_frame_host,
+ const GURL& url) {}
+
protected:
friend class base::RefCounted<Navigator>;
virtual ~Navigator() {}

Powered by Google App Engine
This is Rietveld 408576698