Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 379143002: PlzNavigate: implement RequestNavigation in the no live renderer case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Charlie's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 19 matching lines...) Expand all
30 // objects that are using it and will be released once all nodes that use it are 30 // objects that are using it and will be released once all nodes that use it are
31 // freed. The Navigator is bound to a single frame tree and cannot be used by 31 // freed. The Navigator is bound to a single frame tree and cannot be used by
32 // multiple instances of FrameTree. 32 // multiple instances of FrameTree.
33 // TODO(nasko): Move all navigation methods, such as didStartProvisionalLoad 33 // TODO(nasko): Move all navigation methods, such as didStartProvisionalLoad
34 // from WebContentsImpl to this interface. 34 // from WebContentsImpl to this interface.
35 class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> { 35 class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
36 public: 36 public:
37 // Returns the NavigationController associated with this Navigator. 37 // Returns the NavigationController associated with this Navigator.
38 virtual NavigationController* GetController(); 38 virtual NavigationController* GetController();
39 39
40
41 // Notifications coming from the RenderFrameHosts ---------------------------- 40 // Notifications coming from the RenderFrameHosts ----------------------------
42 41
43 // The RenderFrameHostImpl started a provisional load. 42 // The RenderFrameHostImpl started a provisional load.
44 virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host, 43 virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
45 const GURL& url, 44 const GURL& url,
46 bool is_transition_navigation) {}; 45 bool is_transition_navigation) {};
47 46
48 // The RenderFrameHostImpl has failed a provisional load. 47 // The RenderFrameHostImpl has failed a provisional load.
49 virtual void DidFailProvisionalLoadWithError( 48 virtual void DidFailProvisionalLoadWithError(
50 RenderFrameHostImpl* render_frame_host, 49 RenderFrameHostImpl* render_frame_host,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 RenderFrameHostImpl* render_frame_host, 111 RenderFrameHostImpl* render_frame_host,
113 const GURL& url, 112 const GURL& url,
114 const std::vector<GURL>& redirect_chain, 113 const std::vector<GURL>& redirect_chain,
115 const Referrer& referrer, 114 const Referrer& referrer,
116 PageTransition page_transition, 115 PageTransition page_transition,
117 WindowOpenDisposition disposition, 116 WindowOpenDisposition disposition,
118 const GlobalRequestID& transferred_global_request_id, 117 const GlobalRequestID& transferred_global_request_id,
119 bool should_replace_current_entry, 118 bool should_replace_current_entry,
120 bool user_gesture) {} 119 bool user_gesture) {}
121 120
121 // Will crash the browser if |render_frame_host| is a Web-UI renderer that
122 // tries to display a non Web UI |url|.
123 virtual void CheckWebUIRendererDoesNotDisplayNormalURL(
Charlie Reis 2014/08/05 23:59:51 This is really a private helper function. We shou
124 RenderFrameHostImpl* render_frame_host,
125 const GURL& url) {}
126
122 protected: 127 protected:
123 friend class base::RefCounted<Navigator>; 128 friend class base::RefCounted<Navigator>;
124 virtual ~Navigator() {} 129 virtual ~Navigator() {}
125 }; 130 };
126 131
127 } // namespace content 132 } // namespace content
128 133
129 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 134 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698