Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 376803002: [DevTools] Color values should be case insensitive while suggestions should be case aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 376803002: [DevTools] Color values should be case insensitive while suggestions should be case aware (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments done! Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/Source/devtools/front_end/elements/StylesSidebarPane.js b/Source/devtools/front_end/elements/StylesSidebarPane.js

index 0a197a6716c82a828f1ead602c7a25e5027535b6..7f6aab98255b7495c09c973ee7b6dc51081fa665 100644

--- a/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -2307,7 +2307,11 @@ WebInspector.StylePropertyTreeElementBase.prototype = {

}

var colorValueElement = document.createElement("span");

- colorValueElement.textContent = color.toString(format);

+ if (format === WebInspector.Color.Format.Original) {

apavlov 2014/07/08 13:04:08 No braces around single-statement blocks in Blink,

+ colorValueElement.textContent = text;

+ } else {

+ colorValueElement.textContent = color.toString(format);

+ }

/**

* @param {string} curFormat

« no previous file with comments | « LayoutTests/FlakyTests ('k') | Source/devtools/front_end/sdk/CSSMetadata.js » ('j') | Source/devtools/front_end/ui/TextPrompt.js » ('J')