Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: Source/devtools/front_end/sdk/CSSMetadata.js

Issue 376803002: [DevTools] Color values should be case insensitive while suggestions should be case aware (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments done! Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/CSSMetadata.js
diff --git a/Source/devtools/front_end/sdk/CSSMetadata.js b/Source/devtools/front_end/sdk/CSSMetadata.js
index d43d57d73e9516306c4899f2dd77ad53d8702945..0db17d84705707c92ea1d01adda7de5451e4304c 100644
--- a/Source/devtools/front_end/sdk/CSSMetadata.js
+++ b/Source/devtools/front_end/sdk/CSSMetadata.js
@@ -76,7 +76,7 @@ WebInspector.CSSMetadata.cssPropertiesMetainfo = new WebInspector.CSSMetadata([]
*/
WebInspector.CSSMetadata.isColorAwareProperty = function(propertyName)
{
- return WebInspector.CSSMetadata._colorAwareProperties[propertyName] === true;
+ return !!WebInspector.CSSMetadata._colorAwareProperties[propertyName.toLowerCase()];
}
/**
@@ -727,7 +727,7 @@ WebInspector.CSSMetadata.keywordsForProperty = function(propertyName)
var descriptor = WebInspector.CSSMetadata.descriptor(propertyName);
if (descriptor && descriptor.values)
acceptedKeywords.push.apply(acceptedKeywords, descriptor.values);
- if (propertyName in WebInspector.CSSMetadata._colorAwareProperties)
+ if (WebInspector.CSSMetadata.isColorAwareProperty(propertyName))
acceptedKeywords.push.apply(acceptedKeywords, WebInspector.CSSMetadata._colors);
return new WebInspector.CSSMetadata(acceptedKeywords);
}
@@ -740,6 +740,7 @@ WebInspector.CSSMetadata.descriptor = function(propertyName)
{
if (!propertyName)
return null;
+ propertyName = propertyName.toLowerCase();
var unprefixedName = propertyName.replace(/^-webkit-/, "");
var entry = WebInspector.CSSMetadata._propertyDataMap[propertyName];
if (!entry && unprefixedName !== propertyName)

Powered by Google App Engine
This is Rietveld 408576698