Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorInstrumentation.idl
diff --git a/Source/core/inspector/InspectorInstrumentation.idl b/Source/core/inspector/InspectorInstrumentation.idl
index 49e6a1aca3d189f038b916a6fff9985aecd1f21b..ec7123556858444bf340959cf05636c328056ea8 100644
--- a/Source/core/inspector/InspectorInstrumentation.idl
+++ b/Source/core/inspector/InspectorInstrumentation.idl
@@ -479,17 +479,13 @@ interface InspectorInstrumentation {
interface InspectorConsoleInstrumentation {
+#include "core/inspector/ConsoleMessage.h"
vsevik 2014/08/08 13:21:01 Can we replace this with a forward declaration?
kozyatinskiy1 2014/08/08 14:02:13 I suppose no. In WebKit ilds there is no usage of
aandrey 2014/08/08 15:00:54 I modified the CodeGeneratorInstrumentation.py in
#include "core/inspector/ScriptArguments.h"
#include "core/inspector/ScriptCallStack.h"
- // FIXME: Convert to ScriptArguments to match non-worker context.
// Use the same implementation as above as a similar method dispatched on Page.
[Console]
- void addMessageToConsole(ExecutionContext* context, MessageSource source, MessageType type, MessageLevel level, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack, unsigned long requestIdentifier = 0);
-
- // Use the same implementation as above as a similar method dispatched on Page.
- [Console]
- void addMessageToConsole(ExecutionContext* context, MessageSource source, MessageType type, MessageLevel level, const String& message, const String& scriptId, unsigned lineNumber, unsigned columnNumber, ScriptState* state, unsigned long requestIdentifier = 0);
+ void addMessageToConsole(ExecutionContext* context, ConsoleMessage* consoleMessage);
[Console, Debugger]
void addConsoleAPIMessageToConsole(ExecutionContext* context, MessageType type, MessageLevel level, const String& message, ScriptState* state, PassRefPtrWillBeRawPtr<ScriptArguments> arguments, unsigned long requestIdentifier = 0);

Powered by Google App Engine
This is Rietveld 408576698