DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Source/core/inspector/InspectorInstrumentation.idl

 /*
 * Copyright (C) 2013 Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
 *     * Redistributions in binary form must reproduce the above
@@ skipping 461 matching lines @@
 
     [Debugger, Inline=FastReturn]
     InspectorInstrumentationCookie traceAsyncCallbackStarting([Keep] ExecutionContext*, int operationId);
 
     [Debugger, Inline=FastReturn]
     void traceAsyncCallbackCompleted(const InspectorInstrumentationCookie&);
 }
 
 interface InspectorConsoleInstrumentation {
 
+#include "core/inspector/ConsoleMessage.h"

[vsevik, 2014/08/08 13:21:01]

Can we replace this with a forward declaration?

[kozyatinskiy1, 2014/08/08 14:02:13]

I suppose no. In WebKit ilds there is no usage of forward declaration. In
documentation: http://www.chromium.org/developers/design-documents/idl-compiler
no words about forward declaration. And when I try to add this - compiler fails.

[aandrey, 2014/08/08 15:00:54]

I modified the CodeGeneratorInstrumentation.py in
https://codereview.chromium.org/383123009/ to support forward declarations, but
it got reverted. You can cherry pick those changes.

 #include "core/inspector/ScriptArguments.h"
 #include "core/inspector/ScriptCallStack.h"
 
-    // FIXME: Convert to ScriptArguments to match non-worker context.
     // Use the same implementation as above as a similar method dispatched on Page.
     [Console]
-    void addMessageToConsole(ExecutionContext* context, MessageSource source, MessageType type, MessageLevel level, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack, unsigned long requestIdentifier = 0);
-
-    // Use the same implementation as above as a similar method dispatched on Page.
-    [Console]
-    void addMessageToConsole(ExecutionContext* context, MessageSource source, MessageType type, MessageLevel level, const String& message, const String& scriptId, unsigned lineNumber, unsigned columnNumber, ScriptState* state, unsigned long requestIdentifier = 0);
+    void addMessageToConsole(ExecutionContext* context, ConsoleMessage* consoleMessage);
 
     [Console, Debugger]
     void addConsoleAPIMessageToConsole(ExecutionContext* context, MessageType type, MessageLevel level, const String& message, ScriptState* state, PassRefPtrWillBeRawPtr<ScriptArguments> arguments, unsigned long requestIdentifier = 0);
 
     [Console]
     void consoleCount(ExecutionContext* context, ScriptState* state, PassRefPtrWillBeRawPtr<ScriptArguments> arguments);
 
     [Timeline, Console]
     void consoleTime([Keep] ExecutionContext* context, const String& title);
 
@@ skipping 28 matching lines @@
 interface InspectorCanvasInstrumentation {
 
 #include "bindings/core/v8/ScriptValue.h"
 
     [Canvas]
     ScriptValue wrapCanvas2DRenderingContextForInstrumentation(Document*, const ScriptValue&);
 
     [Canvas]
     ScriptValue wrapWebGLRenderingContextForInstrumentation(Document*, const ScriptValue&);
 }